Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to sort on multiple criteria #7662

Merged
merged 1 commit into from
Sep 15, 2014
Merged

Add ability to sort on multiple criteria #7662

merged 1 commit into from
Sep 15, 2014

Conversation

colings86
Copy link
Contributor

The terms aggregation can now support sorting on multiple criteria by replacing the sort object with an array or sort object whose order signifies the priority of the sort. The existing syntax for sorting on a single criteria also still works.

Contributes to #6917
Replaces #7588

@colings86
Copy link
Contributor Author

First of the commits is the original from #7588, the second is the fix to the backwards compatibility issues and the intermittent test failures

@jpountz
Copy link
Contributor

jpountz commented Sep 12, 2014

This looks good to me. I think we should push this to 1.x. On master it makes sense to not have this isSingleUserCriteria work-around since it will not have to be able to talk to 1.x releases?

@jpountz jpountz removed the review label Sep 12, 2014
@colings86
Copy link
Contributor Author

Ok, I will push this change and then raise a new PR which removes the workaround on master

The terms aggregation can now support sorting on multiple criteria by replacing the sort object with an array or sort object whose order signifies the priority of the sort. The existing syntax for sorting on a single criteria also still works.

Contributes to #6917
Replaces #7588
@colings86 colings86 merged commit d4e83df into elastic:master Sep 15, 2014
@colings86 colings86 deleted the feature/newMultipleSorts branch September 15, 2014 15:41
@im-denisenko im-denisenko mentioned this pull request Apr 6, 2015
16 tasks
@clintongormley clintongormley changed the title Aggregations: Adds ability to sort on multiple criteria Add ability to sort on multiple criteria Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants