Circuit Breakers: Log if CircuitBreaker is tripping #8050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -79,8 +79,12 @@ public MemoryCircuitBreaker(ByteSizeValue limit, double overheadConstant, Memory | |||
| */ | |||
| public void circuitBreak(String fieldName, long bytesNeeded) throws CircuitBreakingException { | |||
| this.trippedCount.incrementAndGet(); | |||
| throw new CircuitBreakingException("Data too large, data for field [" + fieldName + "] would be larger than limit of [" + | |||
| memoryBytesLimit + "/" + new ByteSizeValue(memoryBytesLimit) + "]"); | |||
| String message = "Data too large, data for field [" + fieldName + "] would be larger than limit of [" + | |||
There was a problem hiding this comment.
This string could be final also
|
LGTM, I vote for INFO level :) |
|
updated the PR |
|
LGTM |
|
since this is a message that we already return to the user, and potentially can be repeated a lot, typically in ES we do those as debug messages. If we decide to change those logging levels, I prefer to do it across the board then to be inconsistent. Btw, what I saw is that most of the times where "info" logging was requested, actually what was missing is adding it to our stats API. |
| memoryBytesLimit + "/" + new ByteSizeValue(memoryBytesLimit) + "]"); | ||
| final String message = "Data too large, data for field [" + fieldName + "] would be larger than limit of [" + | ||
| memoryBytesLimit + "/" + new ByteSizeValue(memoryBytesLimit) + "]"; | ||
| if (logger.isInfoEnabled()) { |
|
I moved back to debug and removed the guard - I don't want this to be controversial |
Today we only throw an exception which might not be logged at all. This commit adds debug logging if we are tripping a CB. Closes elastic#8050
s1monw
added a commit
that referenced
this pull request
Oct 10, 2014
Today we only throw an exception which might not be logged at all. This commit adds debug logging if we are tripping a CB. Closes #8050
s1monw
added a commit
that referenced
this pull request
Oct 10, 2014
Today we only throw an exception which might not be logged at all. This commit adds debug logging if we are tripping a CB. Closes #8050
clintongormley
changed the title
clintongormley
added
the
:Core/Infra/Circuit Breakers
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Today we only throw an exception which might not be logged at all. This commit adds debug logging if we are tripping a CB. Closes elastic#8050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today we only throw an exception which might not be logged at all. this PR adds debug logging if we tripping a CB. It's debug for now but I might even vote for info?