Dangling indices import ignores aliases #8059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dangling indices are indexes found on disk which are not part of the cluster state. By default, we don't delete them but rather import them into the cluster state in order to not accidentally delete data and also allow for the ease of copying index data folders from one cluster to another. Currently, the import logic doesn't check for existing aliases of the same name as the imported dangling index, causing both an index and an alias with the same name. This commit add a protection against this. Note that the index is still kept as dangling and is only deleted from disk after `gateway.local.dangling_timeout` has passed (2 hours). We also change the log message indicating deletion of dangling indices to a `WARN` level.
Closed
| if (currentState.metaData().aliases().containsKey(indexMetaData.index())) { | ||
| logger.warn("ignoring dangled index [{}] on node [{}] due to an existing alias with the same name", | ||
| indexMetaData.index(), request.fromNode); | ||
| continue; |
There was a problem hiding this comment.
I think we should remove the continue here it's dangerous to not import it - rather live with the name clash until it's resolved?
There was a problem hiding this comment.
@bleskes has the concern that this state is not defined in our system (since we protect on it from the "outside"), and the implications of having this clash is not evident. I was leaning towards living with the clash, but since its not defined, this change might be good enough for now.
There was a problem hiding this comment.
ok good - better than an undefined state!
|
LGTM |
bleskes
added a commit
that referenced
this pull request
Oct 15, 2014
Dangling indices are indexes found on disk which are not part of the cluster state. By default, we don't delete them but rather import them into the cluster state in order to not accidentally delete data and also allow for the ease of copying index data folders from one cluster to another. Currently, the import logic doesn't check for existing aliases of the same name as the imported dangling index, causing both an index and an alias with the same name. This commit add a protection against this. Note that the index is still kept as dangling and is only deleted from disk after `gateway.local.dangling_timeout` has passed (2 hours). We also change the log message indicating deletion of dangling indices to a `WARN` level. Closes #8059
clintongormley
added
:Core/Infra/Core
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dangling indices are indexes found on disk which are not part of the cluster state. By default, we don't delete them but rather import them into the cluster state in order to not accidentally delete data and also allow for the ease of copying index data folders from one cluster to another. Currently, the import logic doesn't check for existing aliases of the same name as the imported dangling index, causing both an index and an alias with the same name.
This commit add a protection against this. Note that the index is still kept as dangling and is only deleted from disk after
gateway.local.dangling_timeouthas passed (2 hours).We also change the log message indicating deletion of dangling indices to a
WARNlevel.