Don't catch FNF/NSF exception when reading metadata #8207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
v2.0.0-beta1
v1.5.0
v1.4.0
v1.3.5
>bug
resiliency
review
and removed
>bug
labels
s1monw
force-pushed
the
empty_map_on_no_index
branch
from
6115fa7
to
ab54186
Compare
s1monw
changed the title
|
@bleskes can you take a look at this please? |
| /** | ||
| * Returns a new MetadataSnapshot for the latest commit in this store or | ||
| * an empty snapshot if no index exists or can not be opened | ||
| */ |
There was a problem hiding this comment.
I think it's good to explicitly mention that this may throw an IndexCorruptedException
|
LGTM. Left two minor comments. |
|
@bleskes pushed a new commit |
|
looks great. Thx @s1monw |
When reading metadata we do catch FileNotFound and NoSuchFileExceptions today, log the even and return an empty metadata object. Yet, in some cases this might be the wrong thing todo ie. if a commit point is provided these situations are actually an error and should be rethrown. This commit pushes the responsiblity to the caller to handle this exception. Closes elastic#8207
s1monw
force-pushed
the
empty_map_on_no_index
branch
from
9a29a4b
to
c09af6d
Compare
s1monw
added a commit
that referenced
this pull request
Oct 24, 2014
When reading metadata we do catch FileNotFound and NoSuchFileExceptions today, log the even and return an empty metadata object. Yet, in some cases this might be the wrong thing todo ie. if a commit point is provided these situations are actually an error and should be rethrown. This commit pushes the responsiblity to the caller to handle this exception. Closes #8207
s1monw
added a commit
that referenced
this pull request
Oct 24, 2014
When reading metadata we do catch FileNotFound and NoSuchFileExceptions today, log the even and return an empty metadata object. Yet, in some cases this might be the wrong thing todo ie. if a commit point is provided these situations are actually an error and should be rethrown. This commit pushes the responsiblity to the caller to handle this exception. Closes #8207
s1monw
added a commit
that referenced
this pull request
Oct 24, 2014
When reading metadata we do catch FileNotFound and NoSuchFileExceptions today, log the even and return an empty metadata object. Yet, in some cases this might be the wrong thing todo ie. if a commit point is provided these situations are actually an error and should be rethrown. This commit pushes the responsiblity to the caller to handle this exception. Closes #8207
clintongormley
changed the title
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
When reading metadata we do catch FileNotFound and NoSuchFileExceptions today, log the even and return an empty metadata object. Yet, in some cases this might be the wrong thing todo ie. if a commit point is provided these situations are actually an error and should be rethrown. This commit pushes the responsiblity to the caller to handle this exception. Closes elastic#8207
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
When reading metadata we do catch FileNotFound and NoSuchFileExceptions today, log the even and return an empty metadata object. Yet, in some cases this might be the wrong thing todo ie. if a commit point is provided these situations are actually an error and should be rethrown. This commit pushes the responsiblity to the caller to handle this exception. Closes elastic#8207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading metadata we do catch FileNotFound and NoSuchFileExceptions
today, log the even and return an empty metadata object. Yet, in some cases
this might be the wrong thing todo ie. if a commit point is provided these
situations are actually an error and should be rethrown. This commit
pushes the responsiblity to the caller to handle this exception.