Indices API: Fixed backward compatibility issue #8387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public void onFailure(Throwable e) { | ||
| Throwable rootCause = e; | ||
| if (rootCause instanceof RemoteTransportException) { |
There was a problem hiding this comment.
Maybe use ExceptionsHelper#unwrapCause?
|
Left a few comments, nice work @colings86 ! |
| assertThat(settingsMap.size(), equalTo(1)); | ||
| Settings settings = settingsMap.get("test"); | ||
| assertThat(settings, notNullValue()); | ||
| assertThat(settings.get("index.number_of_shards"), equalTo("1")); |
There was a problem hiding this comment.
FYI if you want (not that it is a problem as it works now) you can leave the randomized number of shards when creating the index and retrieve it through getNumShards("test").numShards which you can use for the comparison.
| } | ||
| } | ||
| GetIndexResponse response = new GetIndexResponse(indices.toArray(new String[indices.size()]), warmers, mappings, | ||
| aliases, indexToSettings); |
There was a problem hiding this comment.
all good to pass in null here as parameter I guess?
|
LGTM |
If a 1.4 node needs to forward a GET index API call to a <1.4 master it cannot use the GET index API endpoints as the master has no knowledge of it. This change detects that the master does not understand the initial request and instead tries it again using the old APIs. If these calls also do not work, an error is returned Closes #8364
| import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertAcked; | ||
| import static org.hamcrest.Matchers.*; | ||
|
|
||
| public class GetIndexBackwardsCompatibilityTests extends ElasticsearchBackwardsCompatIntegrationTest { |
There was a problem hiding this comment.
can we have this test on master as well please?
There was a problem hiding this comment.
added to master in d0da605
clintongormley
added
the
:Data Management/Indices APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a 1.4 node needs to forward a GET index API call to a <1.4 master it cannot use the GET index API endpoints as the master has no knowledge of it. This change detects that the master does not understand the initial request and instead tries it again using the old APIs. If these calls also do not work, an error is returned
Closes #8364