Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quotes to allow spaces in installation path #8428

Closed
wants to merge 1 commit into from

Conversation

vidarkongsli
Copy link

Closes #8441

@clintongormley clintongormley added >enhancement :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts review labels Nov 11, 2014
@clintongormley
Copy link

Hi @vidarkongsli

Thanks for the PR. Please could I ask you to sign the CLA so that we can merge it in?
http://www.elasticsearch.org/contributor-agreement/

@gmarz please could you review this?

@vidarkongsli
Copy link
Author

@clintongormley Jumped through the hoop: signed :)

@gmarz
Copy link
Contributor

gmarz commented Nov 11, 2014

LGTM. Thanks @vidarkongsli 👍

@s1monw
Copy link
Contributor

s1monw commented Nov 12, 2014

@gmarz looks like you can pull this in you got policeman approval on #8441

@uschindler
Copy link
Contributor

LOL

@s1monw
Copy link
Contributor

s1monw commented Nov 12, 2014

@uschindler 👍

@gmarz
Copy link
Contributor

gmarz commented Nov 13, 2014

Merged. Thanks again @vidarkongsli

@s1monw
Copy link
Contributor

s1monw commented Nov 21, 2014

@gmarz can you make sure this issue doesn't exist in our 1.3 branch?

@uschindler
Copy link
Contributor

@s1monw In 1.3.x this worked fine for me in the past, but maybe you have a similar problem in later 1.3 branches.

@gmarz
Copy link
Contributor

gmarz commented Nov 21, 2014

@s1monw Confirmed, this is not an issue in 1.3.

@s1monw
Copy link
Contributor

s1monw commented Nov 21, 2014

thx @gmarz

@clintongormley clintongormley changed the title Added quotes to allow spaces in installation path Packaging: Added quotes to allow spaces in installation path Nov 25, 2014
@clintongormley clintongormley changed the title Packaging: Added quotes to allow spaces in installation path Added quotes to allow spaces in installation path Jun 8, 2015
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v1.4.1 v1.5.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running ES on Windows - spaces issue
6 participants