Ban all usage of Future#cancel(true) #8494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| */ | ||
| public class FutureUtil { |
There was a problem hiding this comment.
All of our utility classes are plural, and you reference FutureUtils in the forbidden apis message also, I think this should be FutureUtils
|
LGTM, left two minor comments |
|
@dakrone thanks for the review I push changes |
|
LGTM! |
s1monw
force-pushed
the
ban_future_cancel
branch
from
577b502
to
709f326
Compare
|
@kimchy any comments on that |
|
LGTM |
Interrupting a thread while blocking on an NIO Read / Write Operation can cause a file to be closed due to the interrupts. This can have unpredictable effects when files are open by index readers etc. we should prevent interruptions across the board if possible. Closes elastic#8494
s1monw
force-pushed
the
ban_future_cancel
branch
from
709f326
to
5c6fe25
Compare
|
@s1monw I think this didn't make it into 1.x? (I can't find it and |
|
@dakrone yeah I wanted it to bake in a bit - will backport |
s1monw
added a commit
that referenced
this pull request
Nov 19, 2014
Interrupting a thread while blocking on an NIO Read / Write Operation can cause a file to be closed due to the interrupts. This can have unpredictable effects when files are open by index readers etc. we should prevent interruptions across the board if possible. Closes #8494 Conflicts: src/main/java/org/elasticsearch/gateway/local/state/meta/LocalGatewayMetaState.java
clintongormley
added
:Core/Infra/Core
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interrupting a thread while blocking on an NIO Read / Write Operation
can cause a file to be closed due to the interrupts. This can have unpredictable
effects when files are open by index readers etc. we should prevent interruptions
across the board if possible.