You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Setting the merge_factor, and other merge policies, from within the YML file are always overridden by the defaults. There is a workaround, which is to set them in a base index template, which will cause them to be taken. This is only an issue in 1.4.0 and 1.4.1.
This came up when trying to set index.merge.policy.merge_factor in elasticsearch.yml to a value other than 10, which is the default. Peaking at the code, the sibling settings are also effected (e.g., index.merge.policy.max_merge_size).
They all get the value set at index-creation time -- defaulting it to the global default if it's unset -- then compare to see if it's different from the global value. If they're different, it uses the index-creation value, which means the global default if it is unset.
The fix is simple, the passed in "default" should just be the global value rather than the global default.
The text was updated successfully, but these errors were encountered:
Due to some unreleased refactorings we lost the persitence of
a perviously set values in MergePolicyProvider. This commit adds this
back and adds a simple unittest.
Closeselastic#8890
Due to some unreleased refactorings we lost the persitence of
a perviously set values in MergePolicyProvider. This commit adds this
back and adds a simple unittest.
Closes#8890
Conflicts:
src/test/java/org/elasticsearch/index/merge/policy/MergePolicySettingsTest.java
Due to some unreleased refactorings we lost the persitence of
a perviously set values in MergePolicyProvider. This commit adds this
back and adds a simple unittest.
Closes#8890
Conflicts:
src/test/java/org/elasticsearch/index/merge/policy/MergePolicySettingsTest.java
Due to some unreleased refactorings we lost the persitence of
a perviously set values in MergePolicyProvider. This commit adds this
back and adds a simple unittest.
Closeselastic#8890
Conflicts:
src/test/java/org/elasticsearch/index/merge/policy/MergePolicySettingsTest.java
Setting the merge_factor, and other merge policies, from within the YML file are always overridden by the defaults. There is a workaround, which is to set them in a base index template, which will cause them to be taken. This is only an issue in 1.4.0 and 1.4.1.
This came up when trying to set
index.merge.policy.merge_factor
inelasticsearch.yml
to a value other than10
, which is the default. Peaking at the code, the sibling settings are also effected (e.g.,index.merge.policy.max_merge_size
).For example, in an
elasticsearch.yml
:After creating any index, you will see something along the lines of
Notice that it's reverting the
merge_factor
(and it's not just a mistake in the log output).All of the providers suffer the from the same issue:
LogDocMergePolicyProvider
LogByteSizeMergePolicyProvider
TieredMergePolicyProvider
They all get the value set at index-creation time -- defaulting it to the global default if it's unset -- then compare to see if it's different from the global value. If they're different, it uses the index-creation value, which means the global default if it is unset.
The fix is simple, the passed in "default" should just be the global value rather than the global default.
The text was updated successfully, but these errors were encountered: