Add offset to date_histogram, replacing pre_offsest and post_offset
#9597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffset' and 'post_offset' Add offset option to 'date_histogram' replacing and simplifying the previous 'pre_offset' and 'post_offset' options. This change is part of a larger clean up task for `date_histogram` from issue elastic#9062.
| @@ -203,41 +201,29 @@ public byte id() { | |||
|
|
|||
| @Override | |||
| public long roundKey(long value) { | |||
| return rounding.roundKey(value + preOffset); | |||
| return rounding.roundKey(value - offset); | |||
There was a problem hiding this comment.
This change alone makes offsets much easier to understand!
cbuescher
added
:Analytics/Aggregations
|
@jpountz added some minor changes. Should this be marked as 'breaking'? I will put the offset option alongside the old options on the 1.x branch now, will issue separate PR for that. |
| } | ||
|
|
||
| @Override | ||
| public void readFrom(StreamInput in) throws IOException { | ||
| rounding = Rounding.Streams.read(in); | ||
| if (in.getVersion().before(Version.V_1_4_0_Beta1)) { |
There was a problem hiding this comment.
cool you are removing these BWC conditionals!! thanks!! I missed them
|
LGTM
Yes. I see you already did. :)
Sounds good, thanks! |
|
Merged with master with d2f852a. |
clintongormley
changed the title
offset to date_histogram, replacing pre_offsest and post_offset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add offset option to 'date_histogram' replacing and simplifying the previous 'pre_offset' and 'post_offset' options.
This change is part of a larger clean up task for
date_histogramfrom issue #9062.