Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parent/child support #107

Closed
costin opened this issue Nov 7, 2013 · 7 comments
Closed

add parent/child support #107

costin opened this issue Nov 7, 2013 · 7 comments

Comments

@costin
Copy link
Member

costin commented Nov 7, 2013

Issue raised for PR #66

@costin
Copy link
Member Author

costin commented Nov 7, 2013

cc @yizeli, @solste7en, @vvakar

@vvakar
Copy link

vvakar commented Nov 7, 2013

Thanks for getting back on this Costin. Is es.write.operation also going to allow upsert (in addition to index|create|update)? Upsert's the one I'm very interested in.

Thanks!
-Val

@costin
Copy link
Member Author

costin commented Nov 7, 2013

Upsert is a dedicate type of update. In fact, the current update is an actual upsert in that it 'merges' the given document with the target. I need to spend some time on verifying the other options but since the document is always present, having update as in using script support might not make sense and simply be unsupported.

@vvakar
Copy link

vvakar commented Nov 7, 2013

Does update also insert if the document is not present?

@costin
Copy link
Member Author

costin commented Nov 7, 2013

Yes (this is what upsert is after all) - this is controlled through es.upsert.doc param which is by default set to true. If it's set to false, it will become just update (that is, only update the doc if it exists).
Apologies if the information is scarce, I'm working on updating the docs once things stabilize.

@vvakar
Copy link

vvakar commented Nov 7, 2013

That's awesome. Thanks for the hard work!

@costin
Copy link
Member Author

costin commented Feb 6, 2014

Closing the issue.

@costin costin closed this as completed Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants