Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add score() back to AbstractSearchScript #8416

Closed
rjernst opened this issue Nov 10, 2014 · 1 comment
Closed

Add score() back to AbstractSearchScript #8416

rjernst opened this issue Nov 10, 2014 · 1 comment
Labels
>bug v1.4.1 v1.5.0 v2.0.0-beta1

Comments

@rjernst
Copy link
Member

rjernst commented Nov 10, 2014

In #6864, score() was removed from AbstractSearchScript, in favor of using doc().score(). However, in #7819, score() was removed from DocLookup. While native scripts can still override setScorer(Scorer), we should make it easier to access the score by keeping stashing the scorer in AbstractScoreScript for them.
@rjernst rjernst mentioned this issue Nov 10, 2014
Closed
rjernst added a commit to rjernst/elasticsearch that referenced this issue Nov 10, 2014
@rjernst
Scripting: Add score() back to AbstractSearchScript
263d2ef 
See elastic#8377
closes elastic#8416
@rjernst rjernst mentioned this issue Nov 10, 2014
Closed
@rjernst rjernst added the review label Nov 10, 2014
@s1monw
Copy link
Contributor

s1monw commented Nov 10, 2014

LGTM

rjernst added a commit that referenced this issue Nov 10, 2014
@rjernst
Scripting: Add score() back to AbstractSearchScript
23211cc 
See #8377
closes #8416
closes #8417
rjernst added a commit that referenced this issue Nov 10, 2014
@rjernst
Scripting: Add score() back to AbstractSearchScript
ce8a729 
See #8377
closes #8416
closes #8417
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@rjernst
Scripting: Add score() back to AbstractSearchScript
a4be167 
See elastic#8377
closes elastic#8416
closes elastic#8417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug v1.4.1 v1.5.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add score() back to AbstractSearchScript rjernst/elasticsearch
3 participants
@clintongormley @rjernst @s1monw