Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant terms aggregation should only employ caching when necessary #5450

Closed
markharwood opened this issue Mar 18, 2014 · 1 comment
Closed

Comments

@markharwood
Copy link
Contributor

The significant_terms aggregation currently creates a cache of document counts per term. This is useful when there are multiple child-level significant_terms aggregations asking for the same background index frequency information for shared terms found in many different buckets.
However, for the simpler case when the significant_terms aggregation is used as a top-level aggregation examining the "single bucket" results of a query then the cache is not useful and so should not be constructed.

The logic for managing this cache is in SignificantTermsAggregatorFactory and a separate issue will be raised to address changing this cache into a new optimised utility class available for use elsewhere e.g. #5396

@markharwood
Copy link
Contributor Author

Closed by 12d1bf8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant