Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recommended autodie for better performance #284

Closed
schwern opened this issue Dec 30, 2014 · 2 comments
Closed

Update recommended autodie for better performance #284

schwern opened this issue Dec 30, 2014 · 2 comments
Labels
need input performance

Comments

@schwern
Copy link
Contributor

schwern commented Dec 30, 2014

@pjf @nthykier

Given what @nthykier had to say about autodie being much faster and using less memory I think we should bump the version. I'd like to leave the required version alone, because performance isn't a requirement and 2.12 is the Debian stable version.

What would you recommend for the recommended version? 2.21 looks like it has the performance improvements. 2.26 has a bunch of bug fixes.
@nthykier
Copy link

Hi,

My take is v2.26 as recommended version.

The v2.23 and v2.24 fixes two outstanding bugs for autodie - namely weakening of the strict pragma and "no autodie" not respecting scope. The latter fix caused a weird issue during global destruction in some error cases and that was fixed in v2.26. The v2.26 release also fixes an annoying issue where a (sys)read/syswrite error could cause it to dump a binary buffer to STDERR (or logs). Finally, the "stacktrace" feature in v2.24 might be a useful sell.

Mind you, none of the problems fixed in v2.26 were (to my knowledge) introduced after v2.12, so none of them are regressions caused by the performance changes. Thus recommending v2.21 is an entirely valid solution on its own. It could make sense if you are aware of distros that only have an older version of autodie in their current or future version of a stable release. Though perl 5.20 ships autodie 2.23, so e.g. Debian Jessie will always supply a performance optimised autodie.

schwern added a commit that referenced this issue Dec 31, 2014
@schwern
Recommend the latest autodie which has significant performance improv…
ac43bed 
…ements.

It's loads much faster and uses much less memory and has significant bug fixes.
None of this is required by perl5i, so I left the required version at what
Debian stable is using.

In the future this can be bumped to a requirement.

For #284
@schwern
Copy link
Contributor Author

schwern commented Dec 31, 2014

Okie doke, thanks for the input!

@schwern schwern closed this as completed Dec 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need input performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schwern @nthykier