Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempting to award a badge again should fail gracefully, not 500 #381

Closed
stickster opened this issue Mar 15, 2018 · 1 comment
Closed

Attempting to award a badge again should fail gracefully, not 500 #381

stickster opened this issue Mar 15, 2018 · 1 comment
Assignees
@abompard
Labels
good first issue Good for new contributors Refactor todo

Comments

@stickster
Copy link

If I attempt to award a badge to a person who already has it, I receive a 500 error. This operation should fail gracefully, either returning to the badge page with a failure notice, or a popup to that effect -- not a server internal error.
@github-actions github-actions bot added the Stale label Apr 12, 2024
@abompard abompard added good first issue Good for new contributors and removed EasyFix labels Apr 17, 2024
@github-actions github-actions bot removed the Stale label Apr 18, 2024
@ryanlerch ryanlerch added the todo label May 1, 2024
@abompard abompard self-assigned this Aug 16, 2024
@abompard
Copy link
Member

I don't seem to be able to reproduce it, I think this has been fixed a while ago without closing this issue. I'm closing it now, if you can reproduce it on your end, please reopen.

abompard added a commit to abompard/tahrir that referenced this issue Aug 16, 2024
@abompard
Fix the error pages
0054454 
- don't put the text inside the image
- add alt text
- use a single error page for all the error codes

Fixes: fedora-infra#381
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard abompard mentioned this issue Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abompard abompard

Labels
good first issue Good for new contributors Refactor todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abompard @stickster @sayanchowdhury @ryanlerch