math: Allow "x" for multiplication #5906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always a bit annoying that
*
requires quoting.So we allow "x" as an alternative, only it needs to be followed by
whitespace to distinguish it from "0x" hexadecimal notation.
See e.g. issue #5650, #5324.
The obvious counterpoints here are that people will still try
*
(i.e. how many people do we save from having to ask?), and that it's a tad unclean. It might even lead to confusion if people try to spell hexadecimal numbers with spaces between them. The counter-counterpoints are that all we can do is try, it's not that unclean and that hex numbers are rarely used, and we don't support arbitrary spaces inside of numbers anyway (python supports_
, but AFAICT it requires writing your own strtod, which isn't my idea of a fun weekend).TODOs: