Allow to also use generate mojo with existing native src files #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirino
added a commit
that referenced
this pull request
Feb 12, 2014
Allow to also use generate mojo with existing native src files
|
Thanks! That looked simple enough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use the maven plugin also with existing JNI code while not using hawtjni to generate it at all.
We would love to make use of this in the netty project to ship our native code ASAP. So it would be awesome if you would consider to include this patch and do a release :)
Thanks for your hard work on this project. It really rocks!
Here you can see the change in action:
https://github.com/netty/netty/blob/native-hawtjni/transport-native-epoll/pom.xml