Fix for classic toUpperCase gotcha when locale is Turkish #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locale.English or things will go wrong when running on the Turkish locale. See http://mattryall.net/blog/2009/02/the-infamous-turkish-locale-bug and other Google results: https://www.google.com/search?q=java+toUpperCase+turkish&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:official&client=firefox-a
davsclaus
added a commit
that referenced
this pull request
Apr 6, 2014
Fix for classic toUpperCase gotcha when locale is Turkish
|
Thanks for reporting. Yeah we had same issue in Camel and ActiveMQ where we fixed this the same way you did. |
|
To make thing more confusing, I have recently seen Locale.ROOT used to deal with this. It is not clear to me which is the best/right fix. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locale.English or things will go wrong when running on the Turkish
locale.
See http://mattryall.net/blog/2009/02/the-infamous-turkish-locale-bug
and other Google results:
https://www.google.com/search?q=java+toUpperCase+turkish&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:official&client=firefox-a