normalize formatting using default idea settings #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| ; |
There was a problem hiding this comment.
example of uneeded ';' should be removed
|
Thanks! |
1 task
gnodet
added a commit
to gnodet/jansi
that referenced
this pull request
Oct 5, 2021
gnodet
added a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on IDEA 2016 default profile (I think).
I did disable javadoc comment formatting else the license headers (which are presently javadocs) get reformatted. Header comment should probably be changed to multi-line single-star comment instead of javadoc double-star comment to avoid problems.
I left imports asis, default configuration seems to want to use * imports and I'm not sure that is what you really want. There are at least a few unused imports that could be removed.
There are also a few other turds I noticed like unneeded ';' in a few places but I left those alone for now too.