Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: nil pointer dereference panic for httputil.ReverseProxy users [1.22 backport] #67375

Closed
gopherbot opened this issue May 14, 2024 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases
Milestone

Comments

@gopherbot
Copy link
Contributor

@neild requested issue #53808 to be considered for backport to the next 1.22 minor release.

@gopherbot please open backport issues. This causes panics for ReverseProxy users, with no workaround.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 14, 2024
@gopherbot gopherbot added this to the Go1.22.4 milestone May 14, 2024
@dmitshur dmitshur changed the title bufio: nil pointer dereference [1.22 backport] net/http: nil pointer dereference panic for httputil.ReverseProxy users [1.22 backport] May 15, 2024
@dmitshur
Copy link
Contributor

We've discussed this candidate and are currently leaning towards rejection: this is an issue that has existed since at least Go 1.18, with difficulty in reliably reproducing it and not many users running into it. It appears the workaround of restarting the server when it does happen is working, even if it's suboptimal.

We should reconsider if a case can be made that this fix is low risk (i.e., the chance of it introducing a new, different bug is very low) and high reward, otherwise let's leave the fix to be available in Go 1.23.

@mdempsky
Copy link
Contributor

Rejected as won't fix. @dmitshur mentions this caused a test to become flaky.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickCandidate Used during the release process for point releases
Projects
None yet
Development

No branches or pull requests

3 participants