Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/trace/v2: TestTraceGCStress/AllocFree failures #67379

Closed
gopherbot opened this issue May 15, 2024 · 3 comments
Closed

internal/trace/v2: TestTraceGCStress/AllocFree failures #67379

gopherbot opened this issue May 15, 2024 · 3 comments
Assignees
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "internal/trace/v2" && test == "TestTraceGCStress/AllocFree"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestTraceGCStress/AllocFree
    reader_test.go:112: unexpected error while reading the trace: no frequency event found
    trace_test.go:596: found bad trace; dumping to test log...
    trace_test.go:597: dumping trace: invalid event type: 0
--- FAIL: TestTraceGCStress/AllocFree (1.26s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 15, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "internal/trace/v2" && test == "TestTraceGCStress/AllocFree"
2024-05-14 21:57 gotip-linux-amd64-longtest go@b86527ec internal/trace/v2.TestTraceGCStress/AllocFree (log)
=== RUN   TestTraceGCStress/AllocFree
    reader_test.go:112: unexpected error while reading the trace: no frequency event found
    trace_test.go:596: found bad trace; dumping to test log...
    trace_test.go:597: dumping trace: invalid event type: 0
--- FAIL: TestTraceGCStress/AllocFree (1.26s)

watchflakes

@mknyszek mknyszek self-assigned this May 20, 2024
@mknyszek mknyszek added this to the Go1.23 milestone May 20, 2024
@mknyszek
Copy link
Contributor

I know what's going on here -- the goroutine stack alloc/free events are occurring in the middle of tracing an event, due to a stack growth. It's able to throw everything off.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/587597 mentions this issue: runtime: skip tracing events that would cause reentrancy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Archived in project
Development

No branches or pull requests

2 participants