Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry/godev: telemetry.go.dev chart view is broken #67397

Closed
hyangah opened this issue May 15, 2024 · 2 comments
Closed

x/telemetry/godev: telemetry.go.dev chart view is broken #67397

hyangah opened this issue May 15, 2024 · 2 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Milestone
Unreleased

Comments

@hyangah
Copy link
Contributor

hyangah commented May 15, 2024

https://telemetry.go.dev/charts/2024-05-07

Screenshot 2024-05-15 at 3 24 48 PM

It was broken from 05/07 because the worker produces chart json file with unexpected Charts in it.

{
    "DateRange": [
        "2024-05-13",
        "2024-05-13"
    ],
    "Programs": [
        {
            "ID": "charts:cmd/compile",
            "Name": "cmd/compile",
            "Charts": [
                null,
                null,
                null,
                null,
                null
            ]
        },
        {
            "ID": "charts:cmd/go",
            "Name": "cmd/go",
            "Charts": [
                null,
                null,
                null,
                null,
                null,
                null
            ]
        },
        ...

And, that caused https://go.googlesource.com/telemetry/+/refs/heads/master/internal/content/telemetrygodev/charts.ts#41 failed.
@gopherbot gopherbot added the telemetry x/telemetry issues label May 15, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 15, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/585479 mentions this issue: godev/cmd/worker: skip empty partition in charts

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. labels May 16, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/591177 mentions this issue: internal/content: run go generate

gopherbot pushed a commit to golang/telemetry that referenced this issue Jun 7, 2024
@hyangah
internal/content: run go generate
221703e 
In order to pick up the change CL 585479 we need to renegerate
the minified javascript.

A test to detect this automatically will be nice, but
I am not sure if the Go project CI has all dependency tools
(esbuild, tsc, ...).

Fixes golang/go#67397

Change-Id: If4e6c5cf9d52c273e385a3db4a9bea4726aa7a08
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/591177
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @hyangah @gopherbot