perf: 优化hyperf启动耗时, 元数据分类缓存, 有效缩短扫描时间 #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
现在增加了缓存机制，理论上扫描时，如果不清除缓存是不会扫描的。。 |
limingxinleo
reviewed
Oct 2, 2019
| unset($exploded[count($exploded) - 1]); | ||
| $dirPath = implode('/', $exploded); | ||
| if (! is_dir($dirPath)) { | ||
| mkdir($dirPath, 0755, true); | ||
| } | ||
| } | ||
|
|
||
| $data = implode(PHP_EOL, [$pathsHash, $cacher->serialize()]); | ||
| file_put_contents($this->cachePath, $data); | ||
| $data = implode(PHP_EOL, [$pathsHash, base64_encode(serialize($meta))]); |
There was a problem hiding this comment.
这里缓存太大了。。整个 ast注解树都进来了，我下午改一下。。
There was a problem hiding this comment.
典型的使用场景: 修改代码->停止服务->重启服务,
而此时就算开启缓存, 由于文件最后修改时间变更, 同样会触发全盘的缓存更新, 所以对于这种典型场景, 缓存就失去了意义
此时 app 和 vendor 分别缓存的优势就体现出来了, 因为对于 hyperf 的使用者来说, 仅会修改 app 下的代码 @limingxinleo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
由于常规开发中 vendor 下的代码一般不会被修改, 所以 vendor 下元数据缓存的利用率就会很高, 此处改动能有效降低
php bin/hyperf.php start启动耗时本机硬件配置:
原本扫描时间: app 大概在 1s 左右, vendor 大概在 5s 左右
优化后缩短在1s左右