-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(): remove checked property in favor of parent value #19449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionitron-bot
bot
added
package: angular
@ionic/angular package
package: core
@ionic/core package
labels
Sep 25, 2019
manucorporat
force-pushed
the
fix-simple-radio-group
branch
from
October 1, 2019 14:45
35d8d4c
to
747915b
Compare
liamdebeasi
force-pushed
the
fix-simple-radio-group
branch
from
January 15, 2020 17:28
83268b0
to
8667626
Compare
liamdebeasi
changed the title
refactor(radio-group): single source of truth
refactor(): remove checked property in favor of value
Jan 16, 2020
liamdebeasi
changed the title
refactor(): remove checked property in favor of value
refactor(): remove checked property in favor of parent value
Jan 16, 2020
brandyscarney
approved these changes
Jan 17, 2020
brandyscarney
requested changes
Jan 17, 2020
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Being able to set checked value on parent group and child elements has caused numerous issues in terms of deadlocking, inconsistent values, etc.
What is the new behavior?
Remove the "checked" properties from children. Developers should now set the
value
property on the parent element in order to indicate which item is selected.Does this introduce a breaking change?
Breaking Changes
Selection Controls
The following components have been updated to remove the
checked
orselected
properties:Developers should set the
value
property on the respective parent components in order to managed checked/selected status.Segment Button
checked
property has been removed. See Selection Controls for more information.Old Usage
New Usage
Radio
checked
property has been removed. See Selection Controls for more information.ion-radio
must be used inside of anion-radio-group
, even if there is only oneion-radio
.Old Usage
New Usage
Select
selected
property has been removed. See Selection Controls for more information.Old Usage
New Usage