-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): add --placeholder-opacity, expose shadow parts #19893
Conversation
0e63102
to
3eb8177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing the UI now
@@ -471,10 +471,10 @@ export class Select implements ComponentInterface { | |||
'select-disabled': disabled, | |||
}} | |||
> | |||
<div class={selectTextClasses}> | |||
<div class={selectTextClasses} part="select-text"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want parts to be prefixed with select? In Segment we just add part="indicator"
since the way you will target would be like:
ion-segment::part(indicator)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I removed the prefix
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Approved once changes are made |
Is this still not working at all for anyone else? I cannot get the color or opacity to change no matter what. I've applied these style variables to the element, parent elements, etc, and no matter what it does not change. Even when the DOM shows it as being there, it's still getting overriden by: .select-placeholder { Tried targeting that specific inner div too in a variety of ways, since the shadow dom shows it as "(open)", but nothing either. Thanks! |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #17446
What is the new behavior?
--placeholder-opacity and
--placeholder-color` css variablesDoes this introduce a breaking change?
Other information