Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slides): check that mutation observer is defined for ssr #20791

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 16, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

When running stencil build --prod in the stencil conference app the following error happens prior to this PR:

[12:28.5]  prerendering failed in 4.75
           s

[ ERROR ]  Hydrate Error: /tutorial
           ReferenceError: MutationObserver is not defined at
           Slides.connectedCallback

What is the new behavior?

  • This fixes that error on the prerender

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Mar 16, 2020
@brandyscarney brandyscarney merged commit e2df046 into master Mar 16, 2020
@brandyscarney brandyscarney deleted the fix-slides-ssr branch March 16, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant