Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate logging in istio-cni #50958

Closed
bleggett opened this issue May 9, 2024 · 4 comments · Fixed by #51074
Closed

Consolidate logging in istio-cni #50958

bleggett opened this issue May 9, 2024 · 4 comments · Fixed by #51074
Assignees
Labels
good first issue Indicates a good first issue for new contributors kind/docs kind/enhancement

Comments

@bleggett
Copy link
Contributor

bleggett commented May 9, 2024

Describe the feature request

Right now if you want to enable logging for the istio-cni daemonset you might try to supply the following granular logLevel config:

level: default:info,cni:debug

this will only show debug logs for the cni plugin (used by ambient or sidecar) but will not show any logs for the ambient controller, or the CNI plugin (sidecar or ambient) install logic, which are registered as different subcomponents within istio-cni - for that you need (I think):

level: default:info,cni:debug,ambient:debug,install:debug

This is confusing, and nonobvious. We should consider using either a common component name for log signaling for everything in istio-cni (istio-cni maybe), or something a bit smarter.

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

[ ] Ambient
[x] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

@bleggett bleggett added the good first issue Indicates a good first issue for new contributors label May 9, 2024
@howardjohn
Copy link
Member

Why not just set all:debug if you want everything?

@bleggett
Copy link
Contributor Author

bleggett commented May 9, 2024

Why not just set all:debug if you want everything?

That will work if you explicitly set cni.logLevel directly/by itself yep. And since cni.logLevel currently ignores the global setting, that's fine, but that still results in having to do something like

--set values.cni.logLevel="all:debug" --set values.global.logging.level="all:info"

if you want to configure cni levels independently of other things in Istio.

ideally I'd want cni.logLevel to inherit the global log config, and it cannot as long as we have ☝️

@yas8say
Copy link

yas8say commented May 9, 2024

Hello, a newbie here. Can you guys help me understand this a bit more

@bleggett bleggett self-assigned this May 15, 2024
bleggett added a commit to bleggett/istio that referenced this issue May 15, 2024
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett added a commit to bleggett/istio that referenced this issue May 15, 2024
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
@bleggett
Copy link
Contributor Author

@yas8say Sorry! I ended up fixing this in #51074 myself because I was already working in the area.

TYVM for volunteering!

bleggett added a commit to bleggett/istio that referenced this issue May 20, 2024
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
istio-testing pushed a commit that referenced this issue May 21, 2024
* Fix #50958

Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>

* Relnote

Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>

* Fixup

Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>

* Fix tests

Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>

* 2 scopes - plugin and agent

Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>

---------

Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Indicates a good first issue for new contributors kind/docs kind/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants