-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate logging in istio-cni
#50958
Comments
Why not just set |
That will work if you explicitly set
if you want to configure cni levels independently of other things in Istio. ideally I'd want |
Hello, a newbie here. Can you guys help me understand this a bit more |
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
* Fix #50958 Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Relnote Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Fixup Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Fix tests Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * 2 scopes - plugin and agent Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> --------- Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Describe the feature request
Right now if you want to enable logging for the
istio-cni
daemonset you might try to supply the following granularlogLevel
config:level: default:info,cni:debug
this will only show debug logs for the cni plugin (used by ambient or sidecar) but will not show any logs for the ambient controller, or the CNI plugin (sidecar or ambient) install logic, which are registered as different subcomponents within
istio-cni
- for that you need (I think):level: default:info,cni:debug,ambient:debug,install:debug
This is confusing, and nonobvious. We should consider using either a common component name for log signaling for everything in
istio-cni
(istio-cni
maybe), or something a bit smarter.Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Ambient
[x] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context
The text was updated successfully, but these errors were encountered: