Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring code coverage back to 95% #5194

Closed
yurishkuro opened this issue Feb 8, 2024 · 6 comments · Fixed by #5457
Closed

Bring code coverage back to 95% #5194

yurishkuro opened this issue Feb 8, 2024 · 6 comments · Fixed by #5457
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

Oddly enough, an upgrade to Go 1.22 (#5180) resulted in almost 2% drop in code coverage.

The delta can be seen here: https://app.codecov.io/gh/jaegertracing/jaeger/commit/5bc6b50c6d3135acbec7a23bd492c743782dda80/indirect-changes

One of the big contributors to low coverage seems to be ./plugin/storage/grpc/shared, where some of the methods are trivially testable.

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Feb 8, 2024
@prakrit55
Copy link
Contributor

i will take this up

yurishkuro added a commit that referenced this issue Feb 14, 2024
## Which problem is this PR solving?
Part of #5194 

## Description of the changes
* adding test


## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Griffin <prakritimandal611@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@yurishkuro yurishkuro changed the title Bring code coverage back to 96% Bring code coverage back to 95% Feb 25, 2024
yurishkuro added a commit that referenced this issue Feb 26, 2024
## Which problem is this PR solving?
- As mentioned in #5194, our coverage dropped below 95%. Until it's
fixed we cannot "merge on green" any PRs that are not violating coverage
restrictions, including dependabot PRs.

## Description of the changes
- Temporarily lower codecov threshold to 94.4% (the current level is
94.43%), until the above issue is fixed.

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
@varshith257
Copy link
Contributor

@yurishkuro Is this issue resolved?

@yurishkuro
Copy link
Member Author

yes, but we need to bump the threshold back to 95 in .codecov.yml

@varshith257
Copy link
Contributor

varshith257 commented May 17, 2024

In readme it's showing 95 in codecov report

@yurishkuro
Copy link
Member Author

I am referring to this:

jaeger/.codecov.yml

Lines 26 to 28 in 14cbcea

# Temporarily lower threshold below 95%
# Tacked in https://github.com/jaegertracing/jaeger/issues/5194
target: 94.4%

@varshith257
Copy link
Contributor

Ok, will work on it and submit PR

yurishkuro added a commit that referenced this issue May 18, 2024
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?

- Fixes #5194 

 ## Description of the changes

-  Updated codecov.yml threshold back to 95%

## How was this change tested?
-  N/A

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Signed-off-by: Vamshi Maskuri <117595548+varshith257@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants