use addon.last_updated in feeds (bug 589012)

jbalogh · Aug 20, 2010 · b1d59a9 · b1d59a9
1 parent 1d46a37
commit b1d59a9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/apps/addons/fixtures/addons/featured.json b/apps/addons/fixtures/addons/featured.json
@@ -242,7 +242,7 @@
             "filename": "yahoo_toolbar-10.0.42-fx.xpi",
             "platform": 1,
             "version": 1001,
-            "datestatuschanged": null,
+            "datestatuschanged": "2007-04-04 12:30:11",
             "size": 169
         }
     },
@@ -258,7 +258,7 @@
             "filename": "del.icio.us_bookmarks-1.0.43-fx.xpi",
             "platform": 1,
             "version": 1003,
-            "datestatuschanged": null,
+            "modified": "2007-04-04 12:30:11",
             "size": 169
         }
     }

diff --git a/apps/browse/feeds.py b/apps/browse/feeds.py
@@ -35,7 +35,7 @@ def item_author_name(self, addon):
 
     def item_pubdate(self, addon):
         """Pubdate for a particuar add-on (<item><pubDate>)"""
-        return addon.created
+        return addon.last_updated
 
     def item_guid(self, addon):
         """Guid for a particuar version (<item><guid>)"""

diff --git a/apps/browse/tests.py b/apps/browse/tests.py
@@ -11,10 +11,10 @@
 
 import amo
 import amo.test_utils
+import addons.cron
 from amo.urlresolvers import reverse
 from amo.helpers import urlparams
 from addons.models import Addon, Category
-from addons.cron import _update_appsupport
 from browse import views, feeds
 from browse.views import locale_display_name
 from translations.models import Translation
@@ -257,6 +257,7 @@ def redirects(from_, to):
         redirects('/recommended', '/featured')
         redirects('/recommended/format:rss', '/featured/format:rss')
 
+
 class TestFeaturedPage(amo.test_utils.ExtraSetup, test_utils.TestCase):
     fixtures = ('base/apps', 'addons/featured')
 
@@ -266,6 +267,7 @@ def test_featured_addons(self):
         response = self.client.get(reverse('browse.featured'))
         eq_([1001, 1003], sorted(a.id for a in response.context['addons']))
 
+
 class TestCategoriesFeed(test_utils.TestCase):
 
     def setUp(self):
@@ -293,9 +295,13 @@ def test_item_guid(self):
         t = self.feed.item_guid(self.addon)
         assert t.endswith(u'/addon/2/versions/v%s' % urllib.urlquote(self.u))
 
+
 class TestFeaturedFeed(amo.test_utils.ExtraSetup, test_utils.TestCase):
     fixtures = ('base/apps', 'addons/featured')
 
+    def setUp(self):
+        addons.cron.addon_last_updated()
+
     def test_feed_elements_present(self):
         """specific elements are present and reasonably well formed"""
         url = reverse('browse.featured.rss')