Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Commit

Permalink
Slider: Initially hide the tooltip
Browse files Browse the repository at this point in the history
Fixes gh-7020
  • Loading branch information
Gabriel Schulhof committed Jan 30, 2014
1 parent 277d379 commit 044a3f8
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
1 change: 1 addition & 0 deletions js/widgets/forms/slider.tooltip.js
Expand Up @@ -61,6 +61,7 @@ $.widget( "mobile.slider", $.mobile.slider, {
if ( value && !this._popup ) {
this._popup = getPopup()
.addClass( "ui-body-" + ( this.options.theme || "a" ) )
.hide()
.insertBefore( this.element );
}
}
Expand Down
7 changes: 6 additions & 1 deletion tests/unit/slider/index.html
Expand Up @@ -14,7 +14,8 @@
<script>
$.testHelper.asyncLoad([
[
"widgets/forms/slider"
"widgets/forms/slider",
"widgets/forms/slider.tooltip"
],
[
"slider_events.js",
Expand Down Expand Up @@ -119,6 +120,10 @@
<input type="range" name="disable-test" id="disable-test" value="17" min="0" max="100"/>
</label>

<label>Tooltip slider:
<input type="range" name="tooltip-test" id="tooltip-test" value="17" min="0" max="100" data-nstest-popup-enabled="true"/>
</label>

</div>

<div id="enhancetest">
Expand Down
7 changes: 7 additions & 0 deletions tests/unit/slider/slider_core.js
Expand Up @@ -67,6 +67,13 @@
ok( ! $( "#textinput-test" ).parents().is( "div.ui-input-text" ), "slider input is not wrapped in div.ui-input-text" );
});

test( "slider tooltip", function() {
var tooltip = $( "#tooltip-test" ).siblings( "div.ui-slider-popup" );

deepEqual( tooltip.length, 1, "is present" );
deepEqual( tooltip.is( ":visible" ), false, "is initially hidden" );
});

test( "slider is enabled/disabled correctly", function() {
var slider = $( "#disable-test" ),
track = slider.siblings( "div" );
Expand Down

0 comments on commit 044a3f8

Please sign in to comment.