Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

pagecontainer("load") does not return promise #6900

Closed
marcuskrahl opened this issue Jan 8, 2014 · 0 comments
Closed

pagecontainer("load") does not return promise #6900

marcuskrahl opened this issue Jan 8, 2014 · 0 comments
Milestone
1.4.3

Comments

@marcuskrahl
Copy link
Contributor

The current API docs for version 1.4.0 state that the method load of pagecontainer returns a promise to keep track of the load operation:

http://api.jquerymobile.com/pagecontainer/#method-load

The now deprecated $.mobile.loadPage method also returns a promise so this seems to be the desired behaviour.
As of now, the pagecontainer("load") method creates a deferred, but does not return it as a promise.

This behaviour is reproducable in the following test page:
http://jsbin.com/IFolanOW/72
marcuskrahl pushed a commit to marcuskrahl/jquery-mobile that referenced this issue Jan 8, 2014
Page container: the load method now returns a promise to comply with …
ed81cf7 
…the docs. Fixed jquery-archive#6900. pagecontainer("load") does not return promise
@marcuskrahl marcuskrahl mentioned this issue Jan 8, 2014
Closed
marcuskrahl added a commit to marcuskrahl/jquery-mobile that referenced this issue Feb 13, 2014
@marcuskrahl
Page container: the load method now correctly returns a promise jquer…
afabafa 
…y-archive#6901

The API docs for version 1.4.0 state that the load method of the pagecontainer widget returns a promise. This commit adds this behaviour to the widget to comply with the docs

Fixes jquery-archive#6900
@gabrielschulhof gabrielschulhof modified the milestones: 1.4.3, 1.4.1 Mar 1, 2014
gabrielschulhof pushed a commit that referenced this issue Mar 11, 2014
@marcuskrahl
Page container: the load method now correctly returns a promise
6fd5e67 
The API docs for version 1.4.0 state that the load method of the pagecontainer
widget returns a promise. This commit adds this behaviour to the widget to
comply with the docs.

Closes gh-6901
Fixes gh-6900
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.3
Development

Successfully merging a pull request may close this issue.

Page container: the load method now correctly returns a promise marcuskrahl/jquery-mobile
2 participants
@marcuskrahl @gabrielschulhof