Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Textinput: Textarea must not contain a clear button #7605

Closed
gabrielschulhof opened this issue Aug 2, 2014 · 3 comments
Closed

Textinput: Textarea must not contain a clear button #7605

gabrielschulhof opened this issue Aug 2, 2014 · 3 comments
Assignees
@gabrielschulhof
Labels
Component: Textinput Regression
Milestone
1.4.4

Comments

@gabrielschulhof
Copy link

Currently the clearButton extension adds the anchor even to a textarea. A textarea must only contain text nodes.
@gabrielschulhof gabrielschulhof added this to the 1.4.4 milestone Aug 2, 2014
@gabrielschulhof gabrielschulhof self-assigned this Aug 2, 2014
@gabrielschulhof
Copy link
Author

http://jsbin.com/IFolanOW/548/

@gabrielschulhof
Copy link
Author

Unfortunately, this is a regression from 1.3.2: http://jsbin.com/IFolanOW/549/

@gabrielschulhof
Copy link
Author

It's also added to sliders: http://jsbin.com/IFolanOW/551/

gabrielschulhof pushed a commit that referenced this issue Aug 2, 2014
Textinput: Do not append clear button if there is no wrapper
afd278c 
Fixes gh-7605
gabrielschulhof pushed a commit that referenced this issue Aug 22, 2014
Textinput: Do not concatenate clearBtnText value into HTML snippet
516b791 
clearBtnText must be assigned via .attr( "title" ) to the title and via .text()
to the contents of the clear button anchor.

Do not append clear button to textarea elements.

(cherry picked from commit 5197c10)

Closes gh-7604
Fixes gh-7603
Fixes gh-7605
agcolom pushed a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@agcolom
Textinput: Do not concatenate clearBtnText value into HTML snippet
2d552ee 
clearBtnText must be assigned via .attr( "title" ) to the title and via .text()
to the contents of the clear button anchor.

Do not append clear button to textarea elements.

Closes jquery-archivegh-7604
Fixes jquery-archivegh-7603
Fixes jquery-archivegh-7605
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielschulhof gabrielschulhof

Labels
Component: Textinput Regression
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
1 participant
@gabrielschulhof