-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clusterapi): per nodeGroup autoscaling options #6743
Conversation
Hi @mweibel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ping @elmiko - maybe you have some time to review this other PR of mine. Thanks :) or give /ok-to-test would also be nice 👍 |
apologies @mweibel /ok-to-test |
this seems like a cool feature, i need some time to study the PR |
apologies i have not gotten back here sooner, i just want to make sure we don't break anything then i'm fine to move forward with this. i'd like to try and run it through our red hat ci. |
I'm looking forward to using this feature soon :) |
@jds9090 thank you for the comment, i am hoping we will merge this for the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again @mweibel , i think this is a cool feature
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, mweibel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello! @elmiko |
hey @jds9090 , usually when a release is prepared there is an issue from one of the maintainers and we can request specific PRs to be included in the release. apologies for missing this on the last release, i have a feeling it was just an oversight. it should be included in the next release, but now that i am aware of the need i will double check next time. for example, this issue announced a patch release #7016 |
Thank @elmiko for the detailed explanation. I'm relieved to hear that it will be included in the next release. I appreciate your continued attention to this matter and look forward to the next release. Thank you. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements overrding of autoscaling options per NodeGroup (MachineDeployment/Set/Pool). This allows us to improve scale up/down behavior depending on the node groups configuration.
Which issue(s) this PR fixes:
Fixes #6742
Special notes for your reviewer:
The annotation prefix is intentionally does not contain
cluster-api-autoscaler-node-group-
after the slash because the annotation key must be less than 63 chars long.Does this PR introduce a user-facing change?