Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clusterapi): per nodeGroup autoscaling options #6743

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Apr 22, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implements overrding of autoscaling options per NodeGroup (MachineDeployment/Set/Pool). This allows us to improve scale up/down behavior depending on the node groups configuration.

Which issue(s) this PR fixes:

Fixes #6742

Special notes for your reviewer:

The annotation prefix is intentionally does not contain cluster-api-autoscaler-node-group- after the slash because the annotation key must be less than 63 chars long.

Does this PR introduce a user-facing change?

Added configurable autoscaling options to clusterapi provider allowing users to configure e.g. `--scale-down-unneeded-time` on a per node group level.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mweibel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/cluster-api Issues or PRs related to Cluster API provider labels Apr 22, 2024
@mweibel
Copy link
Contributor Author

mweibel commented May 13, 2024

ping @elmiko - maybe you have some time to review this other PR of mine. Thanks :)

or give /ok-to-test would also be nice 👍

@elmiko
Copy link
Contributor

elmiko commented May 13, 2024

apologies @mweibel

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2024
@elmiko
Copy link
Contributor

elmiko commented May 13, 2024

this seems like a cool feature, i need some time to study the PR

@elmiko
Copy link
Contributor

elmiko commented Jun 7, 2024

apologies i have not gotten back here sooner, i just want to make sure we don't break anything then i'm fine to move forward with this. i'd like to try and run it through our red hat ci.

@jds9090
Copy link

jds9090 commented Jun 13, 2024

I'm looking forward to using this feature soon :)

@elmiko
Copy link
Contributor

elmiko commented Jun 14, 2024

@jds9090 thank you for the comment, i am hoping we will merge this for the next release.

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again @mweibel , i think this is a cool feature

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, mweibel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4e3cc27 into kubernetes:master Jun 27, 2024
6 checks passed
@jds9090
Copy link

jds9090 commented Jul 23, 2024

Hello! @elmiko
I noticed that it was not included in the recent release. Is there a specific criteria for deciding whether something will be included in a particular release? Also, could you let me know when it is expected to be included in a release?

@elmiko
Copy link
Contributor

elmiko commented Jul 23, 2024

hey @jds9090 , usually when a release is prepared there is an issue from one of the maintainers and we can request specific PRs to be included in the release.

apologies for missing this on the last release, i have a feeling it was just an oversight. it should be included in the next release, but now that i am aware of the need i will double check next time.

for example, this issue announced a patch release #7016

@jds9090
Copy link

jds9090 commented Jul 23, 2024

hey @jds9090 , usually when a release is prepared there is an issue from one of the maintainers and we can request specific PRs to be included in the release.

apologies for missing this on the last release, i have a feeling it was just an oversight. it should be included in the next release, but now that i am aware of the need i will double check next time.

for example, this issue announced a patch release #7016

Thank @elmiko for the detailed explanation. I'm relieved to hear that it will be included in the next release. I appreciate your continued attention to this matter and look forward to the next release.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/cluster-api Issues or PRs related to Cluster API provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPI autoscaler does not support per NodeGroup autoscaling options
4 participants