-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AtomicScaleUp ProvisioningClass #6815
Comments
@aleksandra-malinowska is already working on ScaleUp implementation. |
/cc @kisieland |
@yaroslava-serdiuk regarding the 'update ProvisioningRequest injector', I assume you meant adding the new class to supported classes list. But it doesn't seem like this list isn't used anywhere (we don't validate if the request is of the supported class in injector). Is this WAI? I can see why we wouldn't validate class here - we should take into account the requests that were provisioned and will cause a workload to be admitted - but I'm not sure if this was a conscious decision. LMK if I should add validation or just clean up this var. |
I think supported classes list is actually a leftover. We validate provisioning class separately in ScaleUp loop, so it's ok to remove the const to me. I think this additional validation is not needed (and it's easy forget to update the list if we add another prov class).
If ProvReq is failed or Provisioned we do not inject pods: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/processors/provreq/provisioning_request_injector.go#L60 |
/area cluster-autoscaler |
/assign |
|
cc: @x13n |
The Atomic-scale-up Provisioning Class aims to provision the resources required for the specified pods in an atomic way.
Tasks
The text was updated successfully, but these errors were encountered: