-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPA doesn't accept 1.2Gi
in .spec.ResourcePolicy.MinAllowed
#6819
Comments
Also, I don't understand why minAllowed in this test case is "bad minAllowed memory value". autoscaler/vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler_test.go Lines 177 to 197 in 5ecf37a
|
/area vertical-pod-autoscaler |
I think it's because the input is |
I can confirm that this bug exists in VPA 1.1.1. |
It seems as though this issue is related to #4798 |
|
The case for
My understanding is that internally k8s will also end up converting memory into decimal bytes and can only deal with whole bytes, therefore this validation ensures this. See #4774 for some context. |
/close |
@voelzmo: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@voelzmo: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind support |
Which component are you using?:
vertical-pod-autoscaler
What version of the component are you using?:
Component version: 0.14.0 (provided within GKE clusters)
What k8s version are you using (
kubectl version
)?:kubectl version
OutputWhat environment is this in?:
GKE
What did you expect to happen?:
VPA accepts
1.2Gi
in.spec.ResourcePolicy.MinAllowed
What happened instead?:
It doesn't.
How to reproduce it (as minimally and precisely as possible):
Create VPA with MinAllowed with
1.2Gi
Anything else we need to know?:
The text was updated successfully, but these errors were encountered: