Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nvidia-driver-535 for CUDA 12 support #16560

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Bump nvidia-driver-535 for CUDA 12 support #16560

merged 1 commit into from
Oct 15, 2024

Conversation

ddelange
Copy link
Contributor

Close #16557

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ddelange. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2024
@ddelange ddelange mentioned this pull request May 10, 2024
Closed
@hakman
Copy link
Member

hakman commented May 11, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2024
@hakman
Copy link
Member

hakman commented May 16, 2024

@ddelange Please squash the commits and add a description, including why the switch from headless to driver.

@olemarkus Any thoughts about this?

@hakman
Copy link
Member

hakman commented May 16, 2024

/cc @olemarkus

@olemarkus
Copy link
Member

Definitely use the -server package, which does not bring in the xorg-core deps.

@hakman
Copy link
Member

hakman commented May 31, 2024

@ddelange would you like to continue with this PR? 😄

@ddelange
Copy link
Contributor Author

hey 👋 I'm AFK until beginning July. Feel free to take over if you have the time:)

@hakman
Copy link
Member

hakman commented Sep 7, 2024

/test all

@ddelange
Copy link
Contributor Author

@hakman ready to merge?

@hakman
Copy link
Member

hakman commented Oct 15, 2024

Thanks @ddelange. Would you mind also squashing the commits?

@ddelange
Copy link
Contributor Author

done :)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 15, 2024 •
edited
Loading

@ddelange: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-aws-calico-k8s-infra b6e0745 link true /test pull-kops-e2e-k8s-aws-calico-k8s-infra

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 15, 2024
@hakman
Copy link
Member

hakman commented Oct 15, 2024

Thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member

hakman commented Oct 15, 2024

/test pull-kops-verify-terraform

@k8s-ci-robot k8s-ci-robot merged commit 53c3a86 into kubernetes:master Oct 15, 2024
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Oct 15, 2024
@hakman hakman mentioned this pull request Oct 29, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 29, 2024
@k8s-ci-robot
Merge pull request #16926 from hakman/automated-cherry-pick-of-#16560…
c520242 
…-upstream-release-1.30

Automated cherry pick of #16560: Bump nvidia-driver-535-server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

Bump nvidia driver for CUDA 12.1 support
4 participants
@ddelange @k8s-ci-robot @hakman @olemarkus