-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minikube node add fails if --ports was given to initial minikube start #16766
Comments
A REALLY crude fix for this could be provided by something like d00178f. But the matter goes deeper than that. If we're running on docker/podman perhaps things like ExposedPorts which are located on the ClusterConfig struct. As a matter of fact since pods are nodes PERHAPS a few properties could be moved to the node struct: minikube/pkg/minikube/config/types.go Lines 84 to 87 in 856c4f2
But I have absolutely no idea on the implcations (or even feaseability) of doing so. I assume addressing #7366 will bump on that. Just my newbie 2 cents. 😊 |
/triage discuss |
@spowelljr Sorry if it's not common ettiquete mentioning someone who hasn't commented on an issue (please let me know if it is the case) but since issue 7366 has been around for sometime I thought this could be interesting. Again: if mentioning maintainers this way is wrong, feel free to tell me so (and please excuse me for doing so) |
This comment was marked as outdated.
This comment was marked as outdated.
/remove-lifecycle stale |
Hey @everflux Do you mind commenting your impressions on my take on this bug? I would like to work on this, but I wanted to bounce ideas with somene more experienced. |
I have no idea what the implications of your suggestion are.
|
This comment was marked as outdated.
This comment was marked as outdated.
/remove-lifecycle stale |
This seems like a bug, easiest would be to have the exposed ports apply only to the (first) control plane node. Does it even work when creating all the nodes at start, with |
Yes that is broken as well,
|
What Happened?
I started a single node cluster
and wanted to add an additional node afterwards
It uses a different configuration for the added node as the memory shows:
The creation fails since port 80 is bound to the first node
It would be great if the added node would not inherit the "--ports" configuration to make this scenario possible.
log.txt
Attach the log file
log.txt
Operating System
Ubuntu
Driver
Docker
The text was updated successfully, but these errors were encountered: