-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate perf-tests to Go modules #1099
Comments
In general, I'm in favor of this change. Downgrading the priority to important-soon IIRC, we still have vendor dirs in some places because of the travis presubmits. But we know what to do to solve that problem (we should migrate our presubmits to prow, @jprzychodzen created one for building stuff that allowed us to get rid of vendor dir for probes/ and access-token util). Janek, do you want to do it? Alternatively, I think it could be a good first issue (assuming we limit the scope somehow, e.g. to starting with perf-dash). In that case we should lay out a better plan. |
/remove-priority critical-urgent I tried to check if this can be done with a simple PR, but I think there is more work needed to make sure we don't break anything. I could prepare a plan on how to do it, what is exactly in the scope (e.g. migration off Travis to Prow) and then we can discuss timeline. I suspect most of the work from the plan, could be a "good first issue" then. |
Sounds good, thanks! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale @mm4tt - has this been finished? |
I know we migrated some things (like ClusterLoader), but the question is whether we upgraded all. |
We haven't migrated all. There are some that we'll probably never migrate, like benchmark or compare tools. But, we should definitely migrate perf-dash as we're using (building) it a lot. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Note that it's partially done already - most of dirs are already migrated. There are one or two remaining IIRC. |
In perf-tests currently I just see Is there more to do here still, or can this issue be closed? |
Yeah, I think we can close this. |
Yesterday I tried to release new version of perfdash, but failed to build a binary locally due to a missing dependency. I had a look into dependencies and it's a mess. We still use Godeps, which are now deprecated in favor of Go modules. We should migrate to go modules fully, drop support for Godeps and possibly ditch 'vendor/' dirs too (@mm4tt is there any reason we keep them?).
There are couple of reasons for migrating to Go modules fully and dropping support for Godeps.
perfdash
can't be built without local changes to Makefile.Godeps.json
is way less readable).perfdash
code still relies on v1.11.0-alpha.0-2155-g80bd7510df of k/kgodep
is required to run perfdash tests. With Go modules we can use barego
.perfdash/
are run differently than ones in presubmit.The only issue with migrating to go modules might be with relying on k/k as a module (kubernetes/kubernetes#79384). There are existing workaround though.
/priority critical-urgent
The text was updated successfully, but these errors were encountered: