Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate perf-tests to Go modules #1099

Closed
oxddr opened this issue Mar 3, 2020 · 13 comments
Closed

Migrate perf-tests to Go modules #1099

oxddr opened this issue Mar 3, 2020 · 13 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@oxddr
Copy link
Contributor

oxddr commented Mar 3, 2020

Yesterday I tried to release new version of perfdash, but failed to build a binary locally due to a missing dependency. I had a look into dependencies and it's a mess. We still use Godeps, which are now deprecated in favor of Go modules. We should migrate to go modules fully, drop support for Godeps and possibly ditch 'vendor/' dirs too (@mm4tt is there any reason we keep them?).

There are couple of reasons for migrating to Go modules fully and dropping support for Godeps.

  1. perfdash can't be built without local changes to Makefile.
  2. Little visibility into dependencies version (Godeps.json is way less readable).
  3. Vast majority of dependencies is old. perfdash code still relies on v1.11.0-alpha.0-2155-g80bd7510df of k/k
  4. godep is required to run perfdash tests. With Go modules we can use bare go.
  5. Tests run via Makefile under perfdash/ are run differently than ones in presubmit.

The only issue with migrating to go modules might be with relying on k/k as a module (kubernetes/kubernetes#79384). There are existing workaround though.

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 3, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Mar 3, 2020

In general, I'm in favor of this change.
I don't think it's critical-urgent, though. Everything seems to be working (I'm quite sure that building perfdash works if you use proper go version and disable GOMODULES). And it definitely works without any issues for clusterloader2.

Downgrading the priority to important-soon
/priority important-soon

IIRC, we still have vendor dirs in some places because of the travis presubmits. But we know what to do to solve that problem (we should migrate our presubmits to prow, @jprzychodzen created one for building stuff that allowed us to get rid of vendor dir for probes/ and access-token util).

Janek, do you want to do it? Alternatively, I think it could be a good first issue (assuming we limit the scope somehow, e.g. to starting with perf-dash). In that case we should lay out a better plan.

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 3, 2020
@oxddr
Copy link
Contributor Author

oxddr commented Mar 3, 2020

/remove-priority critical-urgent
With #1100 merged, this is indeed not that urgent, as we will be able to again build perfdash at HEAD.

I tried to check if this can be done with a simple PR, but I think there is more work needed to make sure we don't break anything. I could prepare a plan on how to do it, what is exactly in the scope (e.g. migration off Travis to Prow) and then we can discuss timeline. I suspect most of the work from the plan, could be a "good first issue" then.

@k8s-ci-robot k8s-ci-robot removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 3, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Mar 3, 2020

Sounds good, thanks!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 1, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Jun 2, 2020

/remove-lifecycle stale

@mm4tt - has this been finished?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Jun 2, 2020

I know we migrated some things (like ClusterLoader), but the question is whether we upgraded all.

@mm4tt
Copy link
Contributor

mm4tt commented Jun 2, 2020

We haven't migrated all. There are some that we'll probably never migrate, like benchmark or compare tools. But, we should definitely migrate perf-dash as we're using (building) it a lot.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 31, 2020
@wojtek-t
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 31, 2020
@kushthedude
Copy link
Contributor

@mm4tt @wojtek-t I would like to take stab at it.
/assign

@wojtek-t
Copy link
Member

wojtek-t commented Sep 1, 2020

Note that it's partially done already - most of dirs are already migrated. There are one or two remaining IIRC.

@mboersma
Copy link
Contributor

mboersma commented Aug 1, 2024

In perf-tests currently I just see go.mods everywhere, although there is a /vendor directory in dns/dnsperfgo.

Is there more to do here still, or can this issue be closed?

@wojtek-t
Copy link
Member

wojtek-t commented Aug 1, 2024

Yeah, I think we can close this.

@wojtek-t wojtek-t closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

7 participants