Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put menu options on new ReflGui #11079

Closed
5 tasks done
OwenArnold opened this issue Sep 11, 2014 · 1 comment
Closed
5 tasks done

Put menu options on new ReflGui #11079

OwenArnold opened this issue Sep 11, 2014 · 1 comment
Assignees
@eXeC64
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Milestone
Release 3.3

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocked by :

This ticket is blocks : TRAC10238, TRAC10347

Solving the previous issues (see blockers) will mean we can put menus onto the gui.

Remember that in passive MVP, we do not want the views to know anything about processing logic. They must not therefore perform conditional branching based on menu selections, and they should not even launch menus themselves. One way around this would be to create a new MVP group for say the ReflGuiOptions dialog. This could be kicked off by the main presenter.
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 10237

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry labels Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.3 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eXeC64 eXeC64

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.3
Development

No branches or pull requests
2 participants
@eXeC64 @OwenArnold