You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mantid-builder opened this issue
Dec 11, 2012
· 3 comments
Assignees
Labels
FrameworkIssues and pull requests related to components in the FrameworkStaleThis label is automatically applied to issues that are automatically closed by the stale bot
Currently, FindPeaksMD always returns the number of peaks requested. Since the peaks are found and returned in order of decreasing magnitude, if the user requests too many peaks, the list will include many false "noise" peaks at the end of the list. This also seriously impacts the execution time, since many lower intensity boxes must be checked to find those that are far enough away from previously found peaks.
Some possible validity checks (in order of increasing difficulty) include:
The peak intensity should be above a minimum threshold specified by the user.
The total intensity inside the peak region should be at least some multiple of the average background noise.
The net integrated intensity of the peak divided by its estimated standard deviation should be above a minimum theshold (eg. 3).
It should work to add an option to FindPeaksMD, such as "Check Validity". If this option is selected, the algorithm could initially find the peaks in the same way it currently does, but then discard any peak not passing the validity check(s).
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.
To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.
stalebot
added
the
Stale
This label is automatically applied to issues that are automatically closed by the stale bot
label
Feb 24, 2021
FrameworkIssues and pull requests related to components in the FrameworkStaleThis label is automatically applied to issues that are automatically closed by the stale bot
This issue was originally TRAC 6304
Original Reporter: @DennisMikkelson
Currently, FindPeaksMD always returns the number of peaks requested. Since the peaks are found and returned in order of decreasing magnitude, if the user requests too many peaks, the list will include many false "noise" peaks at the end of the list. This also seriously impacts the execution time, since many lower intensity boxes must be checked to find those that are far enough away from previously found peaks.
Some possible validity checks (in order of increasing difficulty) include:
It should work to add an option to FindPeaksMD, such as "Check Validity". If this option is selected, the algorithm could initially find the peaks in the same way it currently does, but then discard any peak not passing the validity check(s).
The text was updated successfully, but these errors were encountered: