Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeakOverlay SpeedUp Part 2 (Guided Optimisation) #7157

Closed
1 task done
OwenArnold opened this issue Dec 12, 2012 · 2 comments
Closed
1 task done

PeakOverlay SpeedUp Part 2 (Guided Optimisation) #7157

OwenArnold opened this issue Dec 12, 2012 · 2 comments
Assignees
@OwenArnold
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 2.4

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocked by :

A pre-requisite for this ticket is to have http://trac.mantidproject.org/mantid/ticket/6291 implemented and to have benchmark performance data from the performance tests.

I can then start working on performance enhancements using the quantitative performance results to verify that the features do actually improve the performance measurably (and definitely do not degrade the performance!). If I can't improve the performance, it would be much better to leave the code alone (optimised for readability). If I can improve the performance, it will be good news, because the SliceViewer must work rapidly.

Ideas for optimisation:

  • Determine whether a peak widget is in range of the slice, if not, simply do not allow it to draw.
  • Look at the setSliceAt method and try to calculate the radius at distance, opacity at distance etc faster.
@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Mantid labels Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 2.4 milestone Jun 3, 2015
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 6311

@OwenArnold
Copy link
Contributor Author

http://trac.mantidproject.org/mantid/raw-attachment/ticket/6311/TEST-SliceViewerTest.PhysicalSphericalPeakTestPerformance.xml
(uploaded by @OwenArnold on 2012-12-12T16:01:48)

http://trac.mantidproject.org/mantid/raw-attachment/ticket/6311/TEST-SliceViewerTest.PhysicalCrossPeakTestPerformance.xml
(uploaded by @OwenArnold on 2012-12-13T11:45:26)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OwenArnold OwenArnold

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 2.4
Development

No branches or pull requests
1 participant
@OwenArnold