Handled baseline image folder identification for non matplotlib projects. #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great idea! My only concern is that I am not familiar with the imp module, so I have no clue how it would behave in py2.6. |
True. |
|
Ahh. I can't remember why I closed this - I now have a need for this change. It appears that this change worked fine on travis-ci's python 2.6... @mdboom will we be able to get this into 1.2? If not, I will have to copy the |
|
Seems fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a project which could really benefit from visual tests. So I thought I would just go ahead and use the decorators in mpl. Unfortunately, there seems to be just one place which hampers this. This PR removes that limitation (provided one structures their project in a similar way to mpl, which I do).
I am hopeful that this can go into 1.2, but if it doesn't it isn't a major disaster.