-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 fixes on text.py #1357
PEP8 fixes on text.py #1357
Conversation
@@ -16,18 +16,15 @@ | |||
from matplotlib.patches import bbox_artist, YAArrow, FancyBboxPatch, \ | |||
FancyArrowPatch, Rectangle | |||
import matplotlib.transforms as mtransforms | |||
from matplotlib.transforms import Affine2D, Bbox, Transform ,\ | |||
BboxBase, BboxTransformTo | |||
from matplotlib.transforms import Affine2D, Bbox, Transform,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a trailing backslash been left in at the end of this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because the import takes two lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In another PR (I can't remember which one) you just added an extra from matplotlib.blah import
statement at the beginning of the wrapped line. There was also a PR that used (
and )
to encase the imported items so they would wrap well. Either of those approaches trumps this one, I think.
@NelleV Can you squash down to one commit? |
@dmcdougall Done ! |
def _update_position_xytext(self, renderer, xy_pixel): | ||
"Update the pixel positions of the annotation text and the arrow patch." | ||
"""Update the pixel positions of the annotation text and the arrow | ||
patch.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-line docstrings should have the triple-quotes on their own lines.
I get a pyflakes warning on this file:
Should I delete it ? |
I'll open a separate issue for that once this is merged. If nobody has any further objections, I'll merge this tomorrow. |
I've rebased matplotlib/master on this branch: I think it is ready to be merged. |
PEP8 fixes on the module text