-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #2097, pgf: get scalable system-fonts from fontconfig, rely on builtin fonts for tests #2117
Conversation
…builtin fonts for tests
This probably requires some more testing. I'm halfway convinced that It would be nice if this output could be checked by a few OSX users:
|
I'm not sure about fc-list on OSX. I have macTeX installed which does not seem to require fontconfig. But I have 3 fc-list binaries installed by other programs. 1 using homebrew package manager as a pango dependency. Xquarts also installes it's own and further more the julia dmg image also installed one. But none of these are TeX dependencies as far as I know. |
This is indeed puzzling. After reading a few http://tex.stackexchange.com posts I'm getting the impression that XeTeX is based on http://tex.stackexchange.com/questions/12881/how-to-get-a-list-of-all-available-ttf-fonts-with-xetex |
@pwuertz: How would you evaluate the status of this vis-a-vis putting another release candidate out? |
I'm not comfortable with this at all. To get this right, this needs a lot more work and organized testing across multiple systems. I'd put this issue to the list of known bugs and fix it once I figured out which TeX engine supports which fonts on which OS and how. |
Ok, fair enough. Just wanted to get your take on this before proceeding. Thanks. |
Given @pwuertz is uncomfortable with this solution, should we punt this to a v1.3 bugfix release rather than keeping it a blocker? |
Yes, let's do that. We can just use the pre-existing 1.3.x label. |
Releasing magical Github ponies: this PR is attempting to fix #2097. |
@@ -138,6 +138,10 @@ def test_pathclip(): | |||
if not check_for('xelatex'): | |||
raise SkipTest('xelatex + pgf is required') | |||
|
|||
rc_xelatex = {'font.family': 'serif', | |||
'pgf.rcfonts': False,} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick: the second line is not well align with the first line of the dict.
I'm confused.. did I close this one? |
It appears so -- it's awfully easy to do by accident. If this isn't resolved, we should also reopen #2097. |
This is due to the commit message of fixes #id or closes #id in a commit message will close the ticket, once the On 17 September 2013 22:01, Michael Droettboom notifications@github.comwrote:
|
Hm, but the PR was not merged. Also, it seems that I cannot open the PR anymore. |
Within the pgf backend, find scalable system-fonts by calling
fc-list
from fontconfig instead of usingmatplotlib.font_manager
.When performing tests, rely on the default built-in fonts instead of
Bitstream Vera Sans
.