New style format str #2461
New style format str #2461
Conversation
| def test_formatstrformatter(): | ||
| ''' | ||
| This is slight overlap with test_axes.test_twin_axis_locaters_formatters, but | ||
| this is a much more through coverage of the format string |
There was a problem hiding this comment.
Typo. TBH, I'd ditch the docstring altogether.
There was a problem hiding this comment.
Why? I think we have a non-zero number of functionally overlapping tests. Given the talk I have see go by about trying to speed up the tests I assume eventually someone will try to par them down and documentation of where overlap is can't hurt. On the other hand, I found this via a pretty simple grep so....
There was a problem hiding this comment.
This test's speed is pretty inconsequential in comparison to the visual tests we have - I just don't feel the docstring adds anything IMHO.
|
I'm in favour of doing this - the format method is the way to go with string formatting, and we should embrace it throughout. IMHO the test could be made simpler - as you say, there is no need to test Python's formatting capabilities, instead we just need to be certain the correct formatting is taking place, so split the test into two, and just check one case per class. |
|
Good stuff @tacaswell. |
|
That test was a bit of me having fun building test structures for the sake of building test structures. Any suggestion on what format string should be tested? |
| does the exact same thing as `FormatStrFormatter`, but for new-style | ||
| formatting strings. Also added `FormatStrFormatterOldStyle` as an | ||
| alias for `FormatStrFormatter` to be ready for that unknown day | ||
| when the printf-style string formatting is depreciated. |
|
I think I addressed everything but the issue of what to name the new class of if the existing one should a) pick up and alias and b) be deprecated |
|
I will admit that I don't really know what to call these, so I will try As for deprecation, I am -1. There is nothing inherently wrong with the |
|
Sorry, I was unclear about what I meant. I mean rename |
|
re-based, re-named and squashed |
Added class `StrMethodFormatter` which is identical to `FormatStrFormatter`
only for new-style ('{}'.format) formatting methods.
|
I like the name. +1 from me. |
|
I'd happily merge this once the PEP8 tests are resolved. |
|
It seems the in-editor pep8 checker is apparently broken on the laptop..... |
Added a new style string Formatter.
Added a Formatter sub-class that can handle new-style format strings.