Fix infinite recursion in units with ndarray subclasses. #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. This seems to break all of the regression tests for unit-related tests, however. You can download the results from Travis here: https://s3.amazonaws.com/matplotlib-test-results/artifacts/3031/3031.1/result_images.tar.bz2 |
|
\me dons paper bag That's what I get for assuming that "surely this can't break anything". I'll fix this up tonight. |
This was partially addressed for masked arrays in matplotlib#2290. However, this does not work for all ndarray sub-classes, like the quantities package. The fix here is to make sure ravel is actually succeeding in changing the shape of the object. If it doesn't just return what we've got.
|
Ok, now that I actually ran the tests, I saw them failing and now they pass--needed to check for the ndarray subclass before checking the shape. |
mdboom
added a commit
that referenced
this pull request
Nov 14, 2013
Fix infinite recursion in units with ndarray subclasses.
|
Cherry-picked to v1.3.x as 66647b0 |
mdboom
added a commit
that referenced
this pull request
Nov 14, 2013
Fix infinite recursion in units with ndarray subclasses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was partially addressed for masked arrays in #2290. However,
this does not work for all ndarray sub-classes, like the quantities
package. The fix here is to make sure ravel is actually succeeding
in changing the shape of the object. If it doesn't just return
what we've got.