_get_xdg_config_dir(), _get_xdg_cache_dir() - Restored for conformity to the standard. #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 21, 2013 23:12
…the functions fulfil the specification of the standard. The previous change to avoid exceptions if no home directory exists broke the standard. Configuration and cache directories could be specified by environment variables independent from the existence of a home directory because they can be elsewhere.
…t_configdir() restored. 1. If an old config $HOME/.matplotlib exists it should be chosen also on Linux. 2. However, if the old config does not exist and xdg_home is None (can be the case in cluster environments) -> do not try to create directory in the non-existing home directory rather in the temporary directory.
|
Closing this PR because it will be merged into master via a PR in branch V1.3.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits result from making matplotlib running on a cluster system where no write access to the home directory exists from compute nodes. With these commits matplotlib can be used in that environment even without setting the environment variables XDG_*. The configuration and cache directory will then be created in the directory for temporary files.
Compare http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html#variables paragraphes 2 and 8.