BUG : improved input clean up in Axes.{h|v}line #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if len(xmax) == 1: | ||
| xmax = np.resize(xmax, y.shape) | ||
| if y.ndim != 1: | ||
| raise ValueError("y must be scalar or 1D") |
There was a problem hiding this comment.
Everything in green above this point can be accomplished with
y = np.ravel(y)
xmin = np.ravel(xmin)
xmax = np.ravel(xmax)or that could even be packed into a single line with map or a list comprehension. After doing this, there is no need to check the number of dimensions.
However, it looks like you are leaving out the critical resize operation. Everything needed could be done like this:
y = np.ravel(y)
xmin = np.resize(xmin, y.shape)
xmax = np.resize(xmax, y.shape)Now, none of the checks in the blocks below are needed, either.
Note: unlike most plotting methods, this one does not support masked arrays; but it never did, so the simplification suggested here is not hurting anything.
- passing in a (N, 1) shaped array as input causes the zipping to generate an extra dimension - closes matplotlib#2197 - use ravel + reshape to do shape validation + getting rid of extra dimension
|
@efiring Changed to use ravel |
efiring
added a commit
that referenced
this pull request
Apr 28, 2014
BUG : improved input clean up in Axes.{h|v}line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate an extra dimension
@efiring I suspect there is a better way to do this.