Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchCollection.__init__ ignores all kwargs if match_original=True #3617

Closed
duncanmmacleod opened this issue Oct 4, 2014 · 2 comments · Fixed by #3619
Closed

PatchCollection.__init__ ignores all kwargs if match_original=True #3617

duncanmmacleod opened this issue Oct 4, 2014 · 2 comments · Fixed by #3619
Milestone

Comments

@duncanmmacleod
Copy link
Contributor

The PatchCollection constructor (__init__) ignores all keyword arguments if match_original=True is given, rather than just ignoring those five variables it takes from the original patches.

Assuming this is a bug, I think this patch fixes the issue.

https://gist.github.com/duncanmmacleod/91976ed41b20c48c5c87

The only thing I'm not sure about is whether the user should be warned if match_original=True and they also give one of the kwargs that gets overwritten?

@duncanmmacleod duncanmmacleod changed the title PatchCollection.__init__ ignores all kwargs if match_original=True PatchCollection.__init__ ignores all kwargs if match_original=True Oct 4, 2014
@tacaswell
Copy link
Member

Seems reasonable, can you open a PR with that patch?

The other way this could go is that more should be extracted from the original patches.

What kwargs in particular are you trying to use?

@tacaswell tacaswell added this to the v1.4.x milestone Oct 4, 2014
@duncanmmacleod
Copy link
Contributor Author

I can easily create a PR for that.

I'm trying to use the label kwarg, which I don't think can be extracted from the patches, but perhaps more of the others can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants