You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PatchCollection constructor (__init__) ignores all keyword arguments if match_original=True is given, rather than just ignoring those five variables it takes from the original patches.
Assuming this is a bug, I think this patch fixes the issue.
The only thing I'm not sure about is whether the user should be warned if match_original=True and they also give one of the kwargs that gets overwritten?
The text was updated successfully, but these errors were encountered:
duncanmmacleod
changed the title
PatchCollection.__init__ ignores all kwargs if match_original=True
PatchCollection.__init__ ignores all kwargs if match_original=True
Oct 4, 2014
The PatchCollection constructor (
__init__
) ignores all keyword arguments ifmatch_original=True
is given, rather than just ignoring those five variables it takes from the original patches.Assuming this is a bug, I think this patch fixes the issue.
https://gist.github.com/duncanmmacleod/91976ed41b20c48c5c87
The only thing I'm not sure about is whether the user should be warned if
match_original=True
and they also give one of the kwargs that gets overwritten?The text was updated successfully, but these errors were encountered: