Privatize Text.cached #2457
Merged
Privatize Text.cached #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be happy to merge this, but I'm a little concious that this could break something between v1.3.0 and v1.3.1. In principle that isn't the problem, but I do think it needs and API changes entry. |
|
I'm fine merging this as it is, but I think it'd be best with an API change entry, in case someone has indeed been using this. |
|
Added API change note. |
|
Thanks @mdboom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This member shows up in the documentation
http://matplotlib.org/api/artist_api.html?highlight=text#matplotlib.text.Text.cached
as reported by @WeatherGod.
I think we privatize this without deprecation. Seriously, no one should have been using this.