Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close figure if context and apply_rcparams are both set. #2914

Merged
merged 1 commit into from Apr 17, 2014

Conversation

astrofrog
Copy link
Contributor

@mdboom - this fixes #2890

@astrofrog
Copy link
Contributor Author

Another option is to not close plots in clear_state and instead to explicitly call plt.close in render_figures when context is not set. What do you think @mdboom?

@mdboom
Copy link
Member

mdboom commented Mar 21, 2014

Do you see any pros/cons to either approach? I've never used this context stuff (I think John wrote it for some papers he wrote with @fperez some time ago), so I don't fully understand the tradeoffs/issues.

@astrofrog
Copy link
Contributor Author

@mdboom - both approaches I'm describing are exactly equivalent, it's more a question of coding style. I'm sure that the logic is correct (i.e. one should not close figures if context is set), so if the coding approach seems ok to you, then I don't see any downsides to merging.

@tacaswell tacaswell added this to the v1.4.0 milestone Mar 24, 2014
@astrofrog
Copy link
Contributor Author

@mdboom - is there anyone else we should ask to review this?

tacaswell added a commit that referenced this pull request Apr 17, 2014
Don't close figure if context and apply_rcparams are both set.
@tacaswell tacaswell merged commit 19069e5 into matplotlib:master Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_apply_rcparams=True causes figure to not appear when updated
4 participants